Don't glob-import overlapping variant names in test/codegen/match-optimizes-away.rs. #46078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
S-waiting-on-review
|
|
||
| #[no_mangle] | ||
| pub fn three_valued(x: Three) -> Three { | ||
| // CHECK-LABEL: @three_valued | ||
| // CHECK-NEXT: {{^.*:$}} | ||
| // CHECK-NEXT: ret i8 %0 | ||
| match x { | ||
| First => First, |
There was a problem hiding this comment.
Oh man, this is plain evil.
I'll make an issue for this.
|
@bors r+ |
|
📌 Commit c3358a4 has been approved by |
kennytm
added
S-waiting-on-bors
|
⌛ Testing commit c3358a4 with merge 270fd731c1acf82ff4edfcb228cbaffce4758fdb... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test added in #45821 wasn't really testing anything because of an overlap between glob imports of enum variants, so it was actually doing
match x { y => y }, alongside triggering warnings.